-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add conversion metrics #23
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-jamie
approved these changes
Oct 18, 2024
fivetran-joemarkiewicz
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature: Add conversion metrics
This PR will result in the following new package version: v0.6.0
We are changing the data type of one field, and customers bringing in the new conversion fields previously via passthrough columns will experience errors if they don't update.
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Feature Updates: Conversion Support!
stg_tiktok_ads__<entity>_report_history
model (ad
,ad_group
,campaign
):real_time_conversion
: Number of times your ad resulted in the optimization event you selected.total_purchase_value
: The total value of purchase events that occurred in your app that were recorded by your measurement partner.total_sales_lead_value
: The monetary worth or potential value assigned to a lead generated through ads.Breaking Changes
conversion
to be an integer rather than a numeric data type, as is the expected behavior of the field.Under the Hood
tiktok_ads_fill_pass_through_columns
andtiktok_ads_add_pass_through_columns
macros to ensure that the new conversion fields are backwards compatible with users who have already included them via passthrough fields.Contributors
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
Ran successfully both with and without passthrough columns
If you had to summarize this PR in an emoji, which would it be?
🕐