Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add conversion metrics #23

Merged
merged 15 commits into from
Oct 21, 2024
Merged

Conversation

fivetran-avinash
Copy link
Contributor

@fivetran-avinash fivetran-avinash commented Oct 2, 2024

PR Overview

This PR will address the following Issue/Feature: Add conversion metrics

This PR will result in the following new package version: v0.6.0

We are changing the data type of one field, and customers bringing in the new conversion fields previously via passthrough columns will experience errors if they don't update.

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Feature Updates: Conversion Support!

  • We have added the following source fields to each stg_tiktok_ads__<entity>_report_history model (ad, ad_group, campaign):
    • real_time_conversion: Number of times your ad resulted in the optimization event you selected.
    • total_purchase_value: The total value of purchase events that occurred in your app that were recorded by your measurement partner.
    • total_sales_lead_value: The monetary worth or potential value assigned to a lead generated through ads.
  • In the event that you were already passing the above fields in via our passthrough columns, the package will dynamically avoid "duplicate column" errors.

The above new field additions are breaking changes for users who were not already bringing in conversion fields via passthrough columns.

Breaking Changes

  • Update conversion to be an integer rather than a numeric data type, as is the expected behavior of the field.

Under the Hood

  • Created tiktok_ads_fill_pass_through_columns and tiktok_ads_add_pass_through_columns macros to ensure that the new conversion fields are backwards compatible with users who have already included them via passthrough fields.

Contributors

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • [NA] dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • [NA] The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

Ran successfully both with and without passthrough columns

If you had to summarize this PR in an emoji, which would it be?

🕐

Copy link
Collaborator

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fivetran-jamie fivetran-jamie merged commit ef98cc3 into main Oct 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants