Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add conversion metrics #20

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

fivetran-avinash
Copy link
Contributor

@fivetran-avinash fivetran-avinash commented Oct 2, 2024

PR Overview

This PR will address the following Issue/Feature: This is part of the add conversion metrics project

This PR will result in the following new package version: v0.6.0

We are changing the data type of one field in the source package that will change it in the transform, and customers bringing in the new conversion fields previously via passthrough columns will experience errors if they don't update.

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Feature Updates: Conversion Support!

  • We have added the following source fields to each tiktok_ads end model:

    • real_time_conversion: Number of times your ad resulted in the optimization event you selected.
    • total_purchase_value: The total value of purchase events that occurred in your app that were recorded by your measurement partner.
    • total_sales_lead_value: The monetary worth or potential value assigned to a lead generated through ads.
    • total_conversion_value: The accumulated value of total_purchase_value and total_sales_lead_value.
  • In the event that you were already passing the above fields in via our passthrough columns, the package will dynamically avoid "duplicate column" errors.

The above new field additions are breaking changes for users who were not already bringing in conversion fields via passthrough columns.

Breaking Changes (in the dbt_tiktok_ads_source package)

  • Update conversion to be an integer rather than a numeric data type, as is the expected behavior of the field. To reflect that data type change, you will need to do a --full-refresh.

Under the Hood

  • Created tiktok_ads_persist_pass_through_columns macro to ensure that the new conversion fields are backwards compatible with users who have already included them via passthrough fields.
  • Added integrity and consistency validation tests within integration_tests folder for the transformation models (to be used by maintainers only).

Contributors

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • [NA] dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • [NA] The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

Unfortunately the JSON issue surrounding age_groups in the ad_group model did not allow us to fully validate on dev data, so we had to use integration tests to validate nothing looks out of the ordinary.

Screenshot 2024-10-02 at 1 59 44 PM

If you had to summarize this PR in an emoji, which would it be?

🕙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant