Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add passthrough columns to card model. #81

Conversation

bramrodenburg
Copy link
Contributor

@bramrodenburg bramrodenburg commented Sep 10, 2024

Please provide your name and company

Bram - Gigs

Link the issue/feature request which this PR is meant to address

#80

Detail what changes this PR introduces and how this addresses the issue/feature request linked above.

Add passthrough variables for the stg_stripe__card model. This can, for example, be used to pull in non-standard columns from Stripe such as description, iin and issuer.

How did you validate the changes introduced within this PR?

Followed the instructions here and tested the changes against our own internal data. Note, I could only do this for iin and issuer, not for description.

Which warehouse did you use to develop these changes?

BigQuery

Did you update the CHANGELOG?

  • Yes

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes

Typically there are additional maintenance changes required before this will be ready for an upcoming release. Are you comfortable with the Fivetran team making a few commits directly to your branch?

  • Yes
  • No

If you had to summarize this PR in an emoji, which would it be?

🐸

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

PR Template

@bramrodenburg bramrodenburg force-pushed the feature/add-non-standard-columns-to-card branch 5 times, most recently from 181fbc8 to f3c7c6e Compare September 13, 2024 10:12
@bramrodenburg bramrodenburg force-pushed the feature/add-non-standard-columns-to-card branch from f3c7c6e to f2d3ac7 Compare September 13, 2024 10:13
@bramrodenburg bramrodenburg changed the title feat: add non-standard columns to card model. feat: add passthrough columns to card model. Sep 13, 2024
@fivetran-jamie
Copy link
Contributor

fivetran-jamie commented Sep 23, 2024

Thanks @bramrodenburg for opening this! Looks great.

One question - Regarding description, did you just not include it in your tests, or was it throwing an error or something like that?

Followed the instructions here and tested the changes against our own internal data. Note, I could only do this for iin and issuer, not for description.

Actually, second question -- are there downstream models in the stripe transform package you'd want these passthrough columns to persist to? Such as stripe__balance_transactions. If so, I can include it in my other stripe PR

Copy link
Contributor

@fivetran-jamie fivetran-jamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and runs great, just a couple of documentation-related suggestions, and see above questions ^

README.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@bramrodenburg
Copy link
Contributor Author

bramrodenburg commented Sep 27, 2024

One question - Regarding description, did you just not include it in your tests, or was it throwing an error or something like that?

I didn't include it in our tests. We asked Stripe at the time to enable the iin and issuer columns, but not the description column. So that's why I didn't include that column in the test.

Actually, second question -- are there downstream models in the stripe transform package you'd want these passthrough columns to persist to? Such as stripe__balance_transactions. If so, I can include it in my other stripe PR

At the moment not. Thanks for asking :)

Looks and runs great, just a couple of documentation-related suggestions, and see above questions ^

Committed your documentation-related suggestions!

@fivetran-jamie fivetran-jamie changed the base branch from main to releases/v0.12.latest September 27, 2024 22:35
@fivetran-jamie
Copy link
Contributor

Woo thank you! This looks great to me. I'm going to merge it into a release branch to make some other changes and CI tests.

Many thanks

@fivetran-jamie fivetran-jamie merged commit 5aa70f0 into fivetran:releases/v0.12.latest Sep 27, 2024
@fivetran-jamie fivetran-jamie mentioned this pull request Sep 27, 2024
7 tasks
fivetran-jamie added a commit that referenced this pull request Oct 2, 2024
* feat: add passthrough columns to card model. (#81)

* feat: add non-standard columns to card model.

* implement feedback from issue

* Apply suggestions from code review

Co-authored-by: Jamie Rodriguez <[email protected]>

---------

Co-authored-by: Jamie Rodriguez <[email protected]>

* polishes

* docs

* explain metadata better

* link

* try something out

* revert

* changelog

* test out removing code block

* revert and use yaml isntead of yml

---------

Co-authored-by: bramrodenburg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants