Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aws kinesis connector #26

Merged
merged 26 commits into from
Oct 9, 2020
Merged

Aws kinesis connector #26

merged 26 commits into from
Oct 9, 2020

Conversation

girishg4t
Copy link
Contributor

Added new AWS Kinesis connector, below are the steps it perform

  1. Connect to kinesis data stream
  2. Finds the shards
  3. Check if any shards are added or removed
  4. Read data from each shard in parallel and call the http endpoint
  5. Depending on the response if success it send message to response stream else send error in error stream

@girishg4t girishg4t changed the title Aws kinesis conn Aws kinesis connector Sep 16, 2020
therahulbhati
therahulbhati reviewed Sep 16, 2020
View reviewed changes
Copy link
Contributor

@therahulbhati therahulbhati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments else LGTM.

aws-kinesis-http-connector/go.sum Show resolved Hide resolved
aws-kinesis-http-connector/go.mod Show resolved Hide resolved
aws-kinesis-http-connector/README.md Outdated Show resolved Hide resolved
@vishal-biyani
Copy link
Member

Fixes #14

@vishal-biyani vishal-biyani mentioned this pull request Oct 5, 2020
Open
therahulbhati
therahulbhati approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@therahulbhati therahulbhati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishal-biyani
Copy link
Member

One last thing @girishg4t - Can you please add it also to https://github.com/fission/keda-connectors/blob/master/README.md#current-connector-list

@vishal-biyani vishal-biyani merged commit 49ff49b into master Oct 9, 2020
@vishal-biyani vishal-biyani deleted the awsKinesisConn branch October 9, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therahulbhati therahulbhati therahulbhati approved these changes

@vishal-biyani vishal-biyani Awaiting requested review from vishal-biyani

Assignees
No one assigned
Labels
hacktoberfest-accepted hacktoberfest-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@girishg4t @vishal-biyani @therahulbhati @gtalekar