-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use FireSim sudo scripts if available #304
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This global stuff is ugly... but I don't think I can think of another solution quickly.
4973ed9
to
abc8d76
Compare
I'm unsure why the |
Does the CI have the same sudo settings as your machine? I see:
This feels like a related failure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't realize the tests had been broken... if you judge the CI failures to be unrelated go ahead and merge
a597627
to
c510768
Compare
Copying to/from the mountpoint is now more complicated. Now it recursively |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for dealing with this
Try to use FireSim's
sudo
scripts when available (instead of defaulting toguestmount
or usingcpio
withsudo
).