Add documentation on how to block installation based on OS versions #6
Conversation
|
@barnson Would it be possible for you to take a look at this documentation update proposal? I'm new to the documentation system here, so the proposal will probably require some adjustments to fit in. Just provide your feedback, and I'll do my best to update the PR accordingly. |
| The sample uses the `SOFTWARE\Microsoft\Windows NT\CurrentVersion\CurrentBuildNumber` registry key to detect the current Windows version. | ||
|
|
||
|
|
||
| # How To: Block installation on missing or too old VCREDIST |
There was a problem hiding this comment.
This is basically obsolete, given that VCredist can no longer be installed by merge module. The check should be in a bundle, which is required to install VCredist. BundlePackage handles all the versioning and detection.
Another issue is that we don't currently have how-tos in the "modern" WiX doc so we need to decide how they're handled. I have to defer to @robmen on that.
There was a problem hiding this comment.
This is basically obsolete, given that VCredist can no longer be installed by merge module. The check should be in a bundle, which is required to install VCredist.
BundlePackagehandles all the versioning and detection.
Please note that this proposal doesn't attempt to install VCredist. It just checks if a sufficient recent version is already installed. The VCredist check seem to work fine when I've tested in a VM with various versions of VCredist installed - or not. That said, it might very well be a better to instead bundle VCredist with the installer if that's the recommended approach.
Maybe I can slim the PR down by removing the VCredist check for now, and instead revisit VCredist handling in a later PR? What do you think @barnson?
There was a problem hiding this comment.
Sounds good.
Ok. I've now slimmed the PR down to only cover an OS version check.
There was a problem hiding this comment.
@barnson Anything else I can do from my end to get some progress on this PR?
forderud
force-pushed
the
os-vcredist-check
branch
from
56a13b9 to
106c42e
Compare
Attempt on addressing wixtoolset/issues#8785 by extending the WiX documentation to also cover an OS version check that I believe is quite common.
forderud
force-pushed
the
os-vcredist-check
branch
from
106c42e to
fe5f3f0
Compare
forderud
changed the title
We don't have enough how-tos to create their own section, but we need to start somewhere. So for now, this is the best place to put the file, and we'll refine its location in the future. |
Migration of wixtoolset/web#300 to the new documentation repo.
Attempt on addressing wixtoolset/issues#8785
and wixtoolset/issues#8786by extending the WiX documentation to also cover such checks that I believe are quite common.Disclaimer: This is my first PR to this project and I'm not familiar with the format. Therefore, please let me know if anything should be changed. Also, please feel free to be picky on the wording and formatting proposal, and I'll do my best to accommodate the feedback. I can also split the proposal into two separate PRs if desired.
References