-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt time-slice selection in High Contrast Mode. #5259
base: main
Are you sure you want to change the base?
Conversation
Make sure the start and end grips look like button, make the outboud of the selection even dimmer and add border to make the selection super obvious.
I'm curious about your opinion on the second commit to have more control hover the icon colors |
6fd0211
to
5e53575
Compare
I think the filter solution is fine but you could use <filter id="--button-icon-color" color-interpolation-filters="sRGB">
<feFlood flood-color="red"/>
<feComposite operator="in" in2="SourceAlpha"/>
</filter> |
Oh, I found an even better solution! You can use <filter id="--use-fill-color" color-interpolation-filters="sRGB">
<feComposite operator="in" in="FillPaint" in2="SourceAlpha"/>
</filter> fill: green;
filter: url(#--use-fill-color); |
Unfortunately this doesn't seem to work in Chromium browser. Would have been nice!
Ah yes that's better, I'll do that |
Using registered property we can get the rgb component from given values that we can then turn into SVG filters that we can then apply on top of the icon we use, in CSS. The time-slice zoom icon takes advantage of this new capability to adapt to High Contrast Mode.
5e53575
to
5c75e6b
Compare
I don't really know flow, so not sure what's needed to please it here |
Make sure the start and end grips look like button, make the
outbound of the selection even dimmer and add border to make
the selection super obvious.
Using registered property we can get the rgb component from
given values that we can then turn into SVG filters that
we can then apply on top of the icon we use, in CSS.
The time-slice zoom icon takes advantage of this new capability
to adapt to High Contrast Mode.