Adapt Tracks to High Contrast Mode. #5252
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch makes the selected track use system colors for selected and hovered style. It also switches from using a box-shadow to a before pseudo element to draw the left selected indicator so it's easier to handle. We also add a few CSS variables simplify computation.
nchevobbe
commented
Dec 10, 2024
src/components/timeline/Track.css
Outdated
Comment on lines
35
to
44
| /* We use a colored pseudo element the track row instead of using border, so | ||
| * that when we select adjacent tracks, we see just one line, without any | ||
| * border on top of it. */ | ||
| .timelineTrackRow::before { | ||
| width: var(--selected-left-border-width); | ||
| content: ""; | ||
| } | ||
|
|
||
| .timelineTrackRow.selected::before { | ||
| background-color: var(--selected-left-border-color); | ||
| } |
There was a problem hiding this comment.
Let me know if I should revert this and only tweak the color for HCM. I'm not sure I understand the original issue with border (except that then the top gray border doesn't seem to go all the way to the left ?)
nchevobbe
force-pushed
the
hcm-selected-track
branch
from
d3ee54b to
583f389
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5252 +/- ##
=======================================
Coverage 88.62% 88.62%
=======================================
Files 308 308
Lines 28096 28096
Branches 7619 7619
=======================================
Hits 24899 24899
Misses 2983 2983
Partials 214 214 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes the selected track use system colors for selected and hovered style.
It also switches from using a box-shadow to a before pseudo element to draw the left selected indicator so it's easier to handle.
We also add a few CSS variables simplify computation.
Here Screenshots track is hovered, GPU Process is selected