Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove frame-ancestors CSP for some endpoints #5234

Conversation

nisargjhaveri
Copy link
Contributor

To allow embedding in profiler in an iframe.

Another attempt at #5170 to scope the changed headers to limited endpoints. I could not find a easy way to test this locally. To be tested with the PR deployment.

Fix #5169.

@nisargjhaveri
Copy link
Contributor Author

This does not work at all. And a few posts around the web (e.g. this post in netlify forums) seems to suggest that adding custom headers does not work well with rewrites (we rewrite everything to /index.html in _redirects). It seems to always pick up the headers defined for the target which is always index.html in our case.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.62%. Comparing base (3593a7b) to head (aca4a9a).
Report is 52 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5234   +/-   ##
=======================================
  Coverage   88.62%   88.62%           
=======================================
  Files         308      308           
  Lines       28074    28074           
  Branches     7606     7606           
=======================================
  Hits        24880    24880           
  Misses       2980     2980           
  Partials      214      214           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@julienw julienw force-pushed the frame-ancestors-scoped branch from b5357c9 to aca4a9a Compare December 5, 2024 08:30
@julienw
Copy link
Contributor

julienw commented Dec 5, 2024

Thanks for trying this!
I'm closing then

@julienw julienw closed this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow embedding the profiler with iframe?
2 participants