Merge branch 'jose/library-load' into 'main'

Update code that loads dynamic libraries See merge request slepc/slepc!179
firedrakeproject · Mar 24, 2021 · 51b1ff1 · 51b1ff1
2 parents bc79791 + ac2c837
commit 51b1ff1
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 14 deletions.
diff --git a/src/eps/tutorials/ex2.c b/src/eps/tutorials/ex2.c
@@ -118,7 +118,7 @@ int main(int argc,char **argv)
          suffix: 1
       test:
          suffix: 2
-         args: -dynamic_library_preload
+         args: -library_preload
 
    testset:
       args: -n 30 -eps_type ciss -terse

diff --git a/src/sys/slepcinit.c b/src/sys/slepcinit.c
@@ -138,7 +138,7 @@ static PetscErrorCode SlepcLoadDynamicLibrary(const char *name,PetscBool *found)
 }
 #endif
 
-#if defined(PETSC_HAVE_THREADSAFETY)
+#if defined(PETSC_USE_SINGLE_LIBRARY) && !(defined(PETSC_HAVE_DYNAMIC_LIBRARIES) && defined(PETSC_USE_SHARED_LIBRARIES))
 SLEPC_EXTERN PetscErrorCode STInitializePackage(void);
 SLEPC_EXTERN PetscErrorCode DSInitializePackage(void);
 SLEPC_EXTERN PetscErrorCode FNInitializePackage(void);
@@ -158,18 +158,19 @@ SLEPC_EXTERN PetscErrorCode LMEInitializePackage(void);
 */
 PetscErrorCode SlepcInitialize_DynamicLibraries(void)
 {
-#if (defined(PETSC_HAVE_DYNAMIC_LIBRARIES) && defined(PETSC_USE_SHARED_LIBRARIES)) || defined(PETSC_HAVE_THREADSAFETY)
   PetscErrorCode ierr;
-#endif
-#if defined(PETSC_HAVE_DYNAMIC_LIBRARIES) && defined(PETSC_USE_SHARED_LIBRARIES)
-  PetscBool      found,preload;
-#endif
+  PetscBool      preload = PETSC_FALSE;
 
   PetscFunctionBegin;
-#if defined(PETSC_HAVE_DYNAMIC_LIBRARIES) && defined(PETSC_USE_SHARED_LIBRARIES)
-  preload = PETSC_FALSE;
-  ierr = PetscOptionsGetBool(NULL,NULL,"-dynamic_library_preload",&preload,NULL);CHKERRQ(ierr);
+#if defined(PETSC_HAVE_THREADSAFETY)
+  /* These must be all initialized here because it is not safe for individual threads to call these initialize routines */
+  preload = PETSC_TRUE;
+#endif
+
+  ierr = PetscOptionsGetBool(NULL,NULL,"-library_preload",&preload,NULL);CHKERRQ(ierr);
   if (preload) {
+#if defined(PETSC_HAVE_DYNAMIC_LIBRARIES) && defined(PETSC_USE_SHARED_LIBRARIES)
+    PetscBool found;
 #if defined(PETSC_USE_SINGLE_LIBRARY)
     ierr = SlepcLoadDynamicLibrary("",&found);CHKERRQ(ierr);
     if (!found) SETERRQ(PETSC_COMM_SELF,PETSC_ERR_FILE_OPEN,"Unable to locate SLEPc dynamic library\nYou cannot move the dynamic libraries!");
@@ -189,10 +190,8 @@ PetscErrorCode SlepcInitialize_DynamicLibraries(void)
     ierr = SlepcLoadDynamicLibrary("lme",&found);CHKERRQ(ierr);
     if (!found) SETERRQ(PETSC_COMM_SELF,PETSC_ERR_FILE_OPEN,"Unable to locate SLEPc LME dynamic library\nYou cannot move the dynamic libraries!");
 #endif
-  }
-#endif
-
-#if defined(PETSC_HAVE_THREADSAFETY)
+#else /* defined(PETSC_HAVE_DYNAMIC_LIBRARIES) && defined(PETSC_USE_SHARED_LIBRARIES) */
+#if defined(PETSC_USE_SINGLE_LIBRARY)
   ierr = STInitializePackage();CHKERRQ(ierr);
   ierr = DSInitializePackage();CHKERRQ(ierr);
   ierr = FNInitializePackage();CHKERRQ(ierr);
@@ -204,7 +203,11 @@ PetscErrorCode SlepcInitialize_DynamicLibraries(void)
   ierr = NEPInitializePackage();CHKERRQ(ierr);
   ierr = MFNInitializePackage();CHKERRQ(ierr);
   ierr = LMEInitializePackage();CHKERRQ(ierr);
+#else
+  SETERRQ(PETSC_COMM_WORLD,PETSC_ERR_SUP,"Cannot use -library_preload with multiple static SLEPc libraries");
 #endif
+#endif /* defined(PETSC_HAVE_DYNAMIC_LIBRARIES) && defined(PETSC_USE_SHARED_LIBRARIES) */
+  }
 
 #if defined(SLEPC_HAVE_HPDDM)
   ierr = KSPRegister(KSPHPDDM,KSPCreate_HPDDM);CHKERRQ(ierr);