Skip to content

OpenMPI forking mode support #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 28, 2025
Merged

OpenMPI forking mode support #21

merged 6 commits into from
May 28, 2025

Conversation

connorjward
Copy link
Collaborator

Replaces #17

I have tested this locally and it seems to work.

@connorjward connorjward requested a review from JHopeCollins May 22, 2025 13:34
JHopeCollins
JHopeCollins requested changes May 28, 2025
View reviewed changes
Copy link
Member

@JHopeCollins JHopeCollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks good to me.
Could you add a job to the CI to run the tests in both forking and non-forking mode? That way we can catch if it stops working again in the future.

@connorjward connorjward requested a review from JHopeCollins May 28, 2025 09:40
@connorjward
Copy link
Collaborator Author

The implementation looks good to me. Could you add a job to the CI to run the tests in both forking and non-forking mode? That way we can catch if it stops working again in the future.

Done.

JHopeCollins
JHopeCollins approved these changes May 28, 2025
View reviewed changes
Copy link
Member

@JHopeCollins JHopeCollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks. LGTM.

@connorjward connorjward merged commit 9cb6526 into main May 28, 2025
12 checks passed
@connorjward connorjward deleted the connorjward/openmpi-support branch May 28, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JHopeCollins JHopeCollins JHopeCollins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@connorjward @JHopeCollins @qbisi