Terminator plots #26
Merged
Terminator plots #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommbendall
requested changes
Aug 30, 2024
| colour_scheme = X2_colour_scheme | ||
| field_label = X2_field_label | ||
| cmap, lines = tomplot_cmap(contours, colour_scheme, remove_contour=None) | ||
| cbar_labelpad = -10 |
There was a problem hiding this comment.
You might want to make these cbar_labelpad values even more negative, so that the label for the colour bar tucks into the colour bar more tightly
| @@ -124,7 +125,7 @@ def terminator_toy( | |||
| xyz = SpatialCoordinate(mesh) | |||
| lamda, theta, _ = lonlatr_from_xyz(xyz[0], xyz[1], xyz[2]) | |||
| k1 = max_value( | |||
| 0, k1_max*cos(great_arc_angle(lamda, lamda_cr, theta, theta_cr)) | |||
| 0, k1_max*cos(great_arc_angle(lamda, theta, lamda_cr, theta_cr)) | |||
There was a problem hiding this comment.
Oops, thanks for spotting this!
transport/terminator_toy.py
Outdated
|
|
||
| g1 = exp(-5*((X-X1)**2 + (Y-Y1)**2 + (Z-Z1)**2)) | ||
| g2 = exp(-5*((X-X2)**2 + (Y-Y2)**2 + (Z-Z2)**2)) | ||
| b0 = 5 |
There was a problem hiding this comment.
Could this be a parameter at the top?
transport/terminator_toy.py
Outdated
| ) | ||
|
|
||
| terminator_toy_defaults = { | ||
| 'ncells_per_edge': 8, # num points per icosahedron edge (ref level 3) | ||
| 'dt': 900.0, # 15 minutes | ||
| 'ncells_per_edge': 16, # num points per icosahedron edge (ref level 4) |
There was a problem hiding this comment.
Suggested change
| 'ncells_per_edge': 16, # num points per icosahedron edge (ref level 4) | |
| 'ncells_per_edge': 16, # num points per icosahedron edge (ref level 4) |
tommbendall
added
bug
tommbendall
approved these changes
Sep 2, 2024
|
Thanks for doing this Tim! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add or update a Gusto case study
Here is a checklist of things that should be done to add a new case study to
the repository:
templates/template_case_study.py. This ensures that the case study:__main__routine with arg-parsing of command line argumentstest_*.pyfile, so that it will be run as part of CIplottingdirectory, with a name that matches the case study scriptfiguresdirectory, with names that match the case study scriptAdd or update a plotting script
Here is a checklist of things that should be done to add a new plotting script to the repository:
templates/template_plotting_script.pyor another acceptable plotting scripttomplot/good_plot_guide.md