Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp examples #541

Merged
merged 20 commits into from
Sep 11, 2024
Merged

Revamp examples #541

merged 20 commits into from
Sep 11, 2024

Conversation

tommbendall
Copy link
Contributor

@tommbendall tommbendall commented Aug 18, 2024

This revamps our examples, making them follow the structure now used in the case studies repository.

Examples are organised as functions, which should allow them to be easily run from the command line or through pytest. They all follow a common pattern.

I also realised that our hydrostatic examples don't use the hydrostatic equations. I've tried to turn them on but this has exposed errors which I will probably fix in a different PR.

@tommbendall tommbendall added tidying Pull requests or issues that involve tidying up code parallel Pull requests or issues relating to parallel capability labels Aug 19, 2024
Copy link
Contributor

@jshipton jshipton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tommbendall !!

@jshipton jshipton merged commit 9fa9cd2 into main Sep 11, 2024
4 checks passed
@jshipton jshipton deleted the TBendall/example_revamp branch September 11, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parallel Pull requests or issues relating to parallel capability tidying Pull requests or issues that involve tidying up code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants