Ensemble parallelism #505
Draft
Ensemble parallelism #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A quick note that |
tommbendall
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running time parallel problems we still need to interact with the io. This PR is a start. The
Ensembleis created first so that the spatial communicator can be passed to the mesh. The ensemble instance is then passed to the timestepper so that it can be passed as required to the io and (in future, or on other branches!) to the time discretisation classes.Here I have sorted out the VTK output. Diagnostics also seem to work, but I have not verified that they are correct. I have not thought about netCDF output or the case where we pick up. I have implemented a test that doesn't check anything other than for hanging. I can see that it does hang if
spatial_parallelism=Truebut this seems to be a pytest issue as it is creating multiple output directories, one for each process.I know @JDBetteridge and @tommbendall have been looking at parallel tests and having issues - would be good to hear what you think!