Eady equations and problems #451
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gusto/configuration.py
Outdated
| """ | ||
| Physical parameters for Incompressible Eady | ||
| """ | ||
| Nsq = 2.5e-05 # squared Brunt-Vaisala frequency (1/s) |
There was a problem hiding this comment.
It's probably a bit dangerous to have N and Nsq both in the parameters with inconsistent values.
tommbendall
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of this is to finally get the Eady equations/problems working again.
The main things to highlight are:
examplesdirectorydiagnostics.pymodule rather than being in their own moduleTrueResidualVdiagnostic should still work, as we can point to the value of the velocity from the start of the timestep