Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build the whole de Rham complex in the domain #402

Merged
merged 7 commits into from
Jul 28, 2023
Merged

Conversation

tommbendall
Copy link
Contributor

@tommbendall tommbendall commented Jul 27, 2023

This PR:

  • expands the space building so that we always build the H1 space and HCurl space (if this exists), thus giving us the whole de Rham complex
  • specifies what the appropriate H1 space is for a particular de Rham complex, which should be used for any vorticity field, thus addressing CG space used for vorticity field #338
  • adds the correct handling for the BDFM space, thus addressing Implement BDFM family #254
  • there is a unit-test for space creation
  • introduces space_names as an argument and property for equations sets. This means that the space for prognostic variables can now be specified by the user (although the defaults are of course the same). This addresses It is assumed that the compatible finite element spaces have the same ordering as the prognostic variables #342
  • the space that was registered as "DG" is also registered "L2"
  • I changed some " to ' in equations.py which just makes the code a bit more consistent

@tommbendall tommbendall marked this pull request as ready for review July 27, 2023 10:15
Copy link
Contributor

@jshipton jshipton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic - thanks @tommbendall !!

@jshipton jshipton merged commit f054fd4 into main Jul 28, 2023
4 checks passed
@jshipton jshipton deleted the de_rham_complex branch July 28, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants