Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated logging capabilities #398

Merged
merged 12 commits into from
Aug 2, 2023
Merged

Updated logging capabilities #398

merged 12 commits into from
Aug 2, 2023

Conversation

JDBetteridge
Copy link
Member

Fixes #394

@JDBetteridge JDBetteridge marked this pull request as ready for review July 26, 2023 14:15
Copy link
Contributor

@tommbendall tommbendall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this Jack, I think it's really helpful to have this pulled out from configuration.py

gusto/timeloop.py Show resolved Hide resolved
gusto/configuration.py Outdated Show resolved Hide resolved
gusto/configuration.py Outdated Show resolved Hide resolved
@JDBetteridge
Copy link
Member Author

There's more to come, I think I can get KSP residuals to be logged. I think what we need is a custom KSP monitor, like I have written here (but much simpler), which logs the exact same information that is output by ksp_monitor_true_residual to the Python logger and then turn off the PETSc internal logger to avoid duplication.

@JDBetteridge
Copy link
Member Author

I think this is ready for another review 🙂

@JDBetteridge JDBetteridge dismissed tommbendall’s stale review August 2, 2023 15:51

Resolved (stale review)

Copy link
Contributor

@tommbendall tommbendall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really good. I can confirm that I have run an example in serial and in parallel on my machine and that the log files appear in the results directory for that example.

Thanks very much!

@tommbendall tommbendall merged commit 1d9fff2 into main Aug 2, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gusto logger should produce a log file
2 participants