Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firedrake warnings fix #396

Merged
merged 5 commits into from
Jul 25, 2023
Merged

Firedrake warnings fix #396

merged 5 commits into from
Jul 25, 2023

Conversation

ta440
Copy link
Collaborator

@ta440 ta440 commented Jul 25, 2023

Fixed the issues raised 'Heed Firedrake warnings #386'.
Specifically removes the references to is_loopy_kernel=True and replaces .split() with subfunctions

jshipton
jshipton approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@jshipton jshipton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic - thanks @ta440 ! Great not to have these warnings appearing anymore!

@jshipton jshipton merged commit d0eee7d into main Jul 25, 2023
1 check passed
@jshipton jshipton deleted the firedrake_warnings_fix branch July 25, 2023 15:26
@jshipton jshipton mentioned this pull request Jul 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jshipton jshipton jshipton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ta440 @jshipton