-
Notifications
You must be signed in to change notification settings - Fork 166
Knook/EquationBC_GMG #4338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release
Are you sure you want to change the base?
Knook/EquationBC_GMG #4338
Conversation
If this is a bugfix this should likely go into Also if you have an MFE that this fixes then please include some sort of test. |
a00a90a
to
2d8da62
Compare
@@ -488,6 +488,7 @@ class EquationBC(object): | |||
def __init__(self, *args, bcs=None, J=None, Jp=None, V=None, is_linear=False, Jp_eq_J=False): | |||
from firedrake.variational_solver import check_pde_args, is_form_consistent | |||
if isinstance(args[0], ufl.classes.Equation): | |||
self.function_arg = firedrake.Constant(0) # so line 286 of mg/ufl_utils.py runs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 286 ufl_utils.py should extract the Functions from the Form in EquationBC
@@ -311,7 +321,8 @@ def mult(self, mat, x, y, inc=False): | |||
x.copy(v) | |||
self.manager.prolong(self.cprimal, self.fprimal) | |||
for bc in self.fbcs: | |||
bc.zero(self.fprimal) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BCBase
or EquationBC
should implement zero()
Necessary code to get geometric multigrid working with
EquationBC
.MFE: