Skip to content

Cjc/vp demo #4320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
May 28, 2025
Merged

Cjc/vp demo #4320

merged 30 commits into from
May 28, 2025

Conversation

colinjcotter
Copy link
Contributor

Description

A 1D Vlasov Poisson demo

Copy link
Member

@JHopeCollins JHopeCollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, most of the comments are just extra detail where the explanations are brief, and a couple of small code changes to avoid warnings.

The only major suggestion is to reorder/reword the explanation of how the null space is dealt with.

@JHopeCollins
Copy link
Member

JHopeCollins commented May 15, 2025

In the future, it could be nice to have a subsequent demo showing how to do this with a single solver, possibly with Irksome too.

The whole thing is linear, and if you have a mixed space with (phi, f) then the matrix is lower triangular so you can do exactly the method you have here with a multiplicative fieldsplit to first solve for phi at the current stage, then calculate the stage increment df using the latest potential velocity.
If you write this as a single system you can also pass it to Irksome to do the RK scheme.

@colinjcotter
Copy link
Contributor Author

Josh, the whole thing isn't linear, because of the a*f appearing in the conservation law.

@JHopeCollins
Copy link
Member

JHopeCollins commented May 16, 2025

Josh, the whole thing isn't linear, because of the a*f appearing in the conservation law.

Ah yes, of course. I got fooled because each field is linear in itself so you need two linear solves, but the Jacobian of the second solve depends on the solution of the first so just doing forward substitution won't update the lower blocks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file shouldn't have been added here.

@@ -0,0 +1,143 @@
import glob
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file shouldn't have been added here.

@connorjward
Copy link
Contributor

This is now only failing the annoying SLATE wrong option check which is known to fail randomly. I am confident that there is nothing wrong with your code.

@dham dham merged commit 16e086e into release May 28, 2025
2 of 4 checks passed
@dham dham deleted the cjc/vp-demo branch May 28, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants