-
Notifications
You must be signed in to change notification settings - Fork 166
Cjc/vp demo #4320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cjc/vp demo #4320
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, most of the comments are just extra detail where the explanations are brief, and a couple of small code changes to avoid warnings.
The only major suggestion is to reorder/reword the explanation of how the null space is dealt with.
In the future, it could be nice to have a subsequent demo showing how to do this with a single solver, possibly with Irksome too. The whole thing is linear, and if you have a mixed space with (phi, f) then the matrix is lower triangular so you can do exactly the method you have here with a multiplicative fieldsplit to first solve for |
Co-authored-by: Josh Hope-Collins <[email protected]>
Co-authored-by: Josh Hope-Collins <[email protected]>
Co-authored-by: Josh Hope-Collins <[email protected]>
Co-authored-by: Josh Hope-Collins <[email protected]>
Co-authored-by: Josh Hope-Collins <[email protected]>
Co-authored-by: Josh Hope-Collins <[email protected]>
Josh, the whole thing isn't linear, because of the a*f appearing in the conservation law. |
Co-authored-by: Josh Hope-Collins <[email protected]>
Co-authored-by: Josh Hope-Collins <[email protected]>
Co-authored-by: Josh Hope-Collins <[email protected]>
Co-authored-by: Josh Hope-Collins <[email protected]>
Co-authored-by: Josh Hope-Collins <[email protected]>
Co-authored-by: Josh Hope-Collins <[email protected]>
Co-authored-by: Josh Hope-Collins <[email protected]>
Co-authored-by: Josh Hope-Collins <[email protected]>
Co-authored-by: Josh Hope-Collins <[email protected]>
Ah yes, of course. I got fooled because each field is linear in itself so you need two linear solves, but the Jacobian of the second solve depends on the solution of the first so just doing forward substitution won't update the lower blocks. |
demos/test_demos_run.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file shouldn't have been added here.
demos/test_demos_run.py
Outdated
@@ -0,0 +1,143 @@ | |||
import glob |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file shouldn't have been added here.
This is now only failing the annoying SLATE wrong option check which is known to fail randomly. I am confident that there is nothing wrong with your code. |
Description
A 1D Vlasov Poisson demo