Fix coarsening for R space #3814
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbrubeck
commented
Oct 21, 2024
| @@ -384,7 +385,8 @@ def create_interpolation(dmc, dmf): | |||
| mat.setType(mat.Type.PYTHON) | |||
| mat.setPythonContext(ctx) | |||
| mat.setUp() | |||
| return mat, None | |||
| rscale = mat.createVecLeft() if row_size == col_size else None | |||
There was a problem hiding this comment.
Not sure whether Right or Left is the correct thing here. But it does not really matter if the sizes are the same.
|
|
pbrubeck
force-pushed
the
pbrubeck/fix/coarsen-dm
branch
from
292191a
to
de93ebc
Compare
pbrubeck
force-pushed
the
pbrubeck/fix/coarsen-dm
branch
from
de93ebc
to
0d1e1e8
Compare
connorjward
requested changes
Oct 23, 2024
|
|
||
| # This test will fail if we raise this warning | ||
| with warnings.catch_warnings(): | ||
| warnings.filterwarnings("error", "Creating new TransferManager", RuntimeWarning) |
There was a problem hiding this comment.
This looks very fragile. If we decided not to emit this warning any more, or even changed the content of the warning message, then this would always pass regardless of whether or not we were actually reusing transfer managers.
Is a better way to do this not to somehow retrieve the transfer managers from whatever mesh/DM they are attached to and check that they are the same?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes two separate issues for multigrid with
Functionsin R.The restriction operator for the R space is square. For these cases PETSc complains if we do not pass a vector to rescale the restriction operator to construct the "cheap" injection, even though it is not necessary, as we already pass the proper injection operator. To fix this we just pass a vector of the appropriate size.
The
parentdmof an R space function sometimes might have a null__setup_hooks__, which makes it impossible to calladd_hookon it. As a workaround, we just skip that call.