Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Stokes macroelements #84

Merged
merged 44 commits into from
Oct 8, 2024
Merged

Add Stokes macroelements #84

merged 44 commits into from
Oct 8, 2024

Conversation

pbrubeck
Copy link

@pbrubeck pbrubeck commented Sep 13, 2024 •
edited
Loading

@pbrubeck pbrubeck force-pushed the pbrubeck/alfeld-sorokina branch 3 times, most recently from 6359db7 to 691d2b8 Compare September 13, 2024 16:01
This was referenced Sep 14, 2024
Merged
Merged
@pbrubeck pbrubeck force-pushed the pbrubeck/alfeld-sorokina branch 3 times, most recently from b7d605f to cf7691e Compare September 24, 2024 17:40
@pbrubeck pbrubeck force-pushed the pbrubeck/alfeld-sorokina branch 2 times, most recently from 82b399a to 64df9c6 Compare September 26, 2024 09:02
rckirby
rckirby requested changes Sep 30, 2024
View reviewed changes
Copy link

@rckirby rckirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not up to date on all the elements, but glad to approve (modulo changes) as part of a process that gets mappings/tests in FInAT + Firedrake.

FIAT/alfeld_sorokina.py Outdated Show resolved Hide resolved
FIAT/arnold_qin.py Outdated Show resolved Hide resolved
FIAT/arnold_qin.py Show resolved Hide resolved
FIAT/P0.py Show resolved Hide resolved
FIAT/alfeld_sorokina.py Show resolved Hide resolved
FIAT/macro.py Show resolved Hide resolved
FIAT/macro.py Show resolved Hide resolved
test/unit/test_hct.py Outdated Show resolved Hide resolved
test/unit/test_macro.py Outdated Show resolved Hide resolved
test/unit/test_macro.py Outdated Show resolved Hide resolved
@pbrubeck pbrubeck changed the title Alfeld-Sorokina triangular macroelement Add Stokes macroelements Oct 1, 2024
@pbrubeck pbrubeck requested a review from rckirby October 1, 2024 16:03
rckirby
rckirby requested changes Oct 1, 2024
View reviewed changes
Copy link

@rckirby rckirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're getting closer. Just a few comments (mainly on doc string).

FIAT/alfeld_sorokina.py Outdated Show resolved Hide resolved
FIAT/alfeld_sorokina.py Show resolved Hide resolved
FIAT/arnold_qin.py Show resolved Hide resolved
FIAT/arnold_qin.py Outdated Show resolved Hide resolved
FIAT/bernardi_raugel.py Show resolved Hide resolved
FIAT/christiansen_hu.py Show resolved Hide resolved
FIAT/christiansen_hu.py Outdated Show resolved Hide resolved
@pbrubeck pbrubeck requested a review from rckirby October 2, 2024 10:48
@pbrubeck pbrubeck merged commit 13131da into master Oct 8, 2024
16 checks passed
@pbrubeck pbrubeck deleted the pbrubeck/alfeld-sorokina branch October 8, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rckirby rckirby Awaiting requested review from rckirby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pbrubeck @rckirby