New base class DIRK_IMEX #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created new base class DIRK_IMEX which now ARS_DIRK_IMEX inherits from. Implicit tableau in ARS methods are now padded so sizing is uniform with methods requiring an implicit first step. Modified DIRKIMEXMethod to allow for implicit first stages. Also combined loops for efficiency Added additional ARS schemes for completeness Added some SSPk schemes from Pareschi and Russo to demonstrate new functionality in SSPK_DIRK_IMEX Updated tests and demos accordingly
There was a problem hiding this comment.
Overall, this looks good to me - many thanks for the great work here! A couple of small issues to fix, and it would be great to get @rckirby's eyes on this as well.
I think the correct fix for the docs build is to edit line 51 of .github/workflows/docs.yml to take v2.5.0 to v3
Fixed a typo in test suite Updated version in docs Changed __init__.py to match style
rckirby
requested changes
Feb 11, 2025
Merged
|
@jbigmanUT : @ScottMacLachlan just fixed the doc building issue for us, and it's merged. Can you merge our master branch to fix that on your PR, as we don't have write permission for you. |
Dictionaries for SSPk and ARS schemes are now stored with their classes Explicit parts of SSPk schemes are now available as a tableau via a new factory. These tableau were also added to the testing in test_explicit.py Testing in test_imex.py is now parameterized by the Butcher tableau
ScottMacLachlan
approved these changes
Feb 13, 2025
rckirby
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created new base class DIRK_IMEX which now ARS_DIRK_IMEX inherits from. Implicit tableau in ARS methods are now padded so sizing is uniform with methods requiring an implicit first step.
Modified DIRKIMEXMethod to allow for implicit first stages. Also combined loops for efficiency
Added remaining ARS schemes for completeness
Added some SSPk schemes from Pareschi and Russo to demonstrate new functionality in SSPK_DIRK_IMEX
Updated tests and demos accordingly