New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DIRK-IMEX and VFS #110

Merged

rckirby merged 2 commits into master from smaclachlan/fix_vfs

Jan 29, 2025

Collaborator

ScottMacLachlan commented Jan 29, 2025

This attempts to fix #109 in one of the two possible ways. Includes a test that fails without the fix.


          Wrap values in float

512a5bd

ScottMacLachlan requested review from rckirby and pbrubeck

January 29, 2025 18:23


          Unrelated test tolerance failure

20116e0

rckirby approved these changes

View reviewed changes

Collaborator

rckirby left a comment

I think this the right thing to do, but we we have a failing tolerance test. It's the Usual Suspect.

rckirby approved these changes

View reviewed changes

rckirby merged commit 3ba45c3 into master

2 checks passed

rckirby deleted the smaclachlan/fix_vfs branch

January 29, 2025 21:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet