New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DIRK boundary conditions #103

Merged

rckirby merged 11 commits into master from smaclachlan/fix_dirk_bcs

Nov 20, 2024

Collaborator

ScottMacLachlan commented Nov 17, 2024 •

edited by pbrubeck

Loading

When BCs were refactored in #98, the DIRK case was left untouched.

This PR aims to correct that, as well as addressing the root problem in #102, where we don't implement the correct DAE-style BCs for explicit schemes

fixes #102


          Remove gblah from DIRK

067ef5e

ScottMacLachlan marked this pull request as draft

November 17, 2024 00:26

ScottMacLachlan added 3 commits

November 16, 2024 21:07


          Add AAb structure to allow explicit case


          More setup for explicit

f1fdf62


          Add BC treatment for explicit plus a test

9e276dc

ScottMacLachlan marked this pull request as ready for review

November 17, 2024 01:36

ScottMacLachlan requested review from rckirby and pbrubeck

November 17, 2024 01:36

ScottMacLachlan mentioned this pull request

new irksome user - explicit RK #100

Closed

pbrubeck reviewed

View reviewed changes

irksome/dirk_stepper.py Outdated Show resolved Hide resolved

pbrubeck reviewed

View reviewed changes

irksome/dirk_stepper.py Outdated Show resolved Hide resolved

pbrubeck reviewed

View reviewed changes

irksome/dirk_stepper.py Outdated Show resolved Hide resolved

pbrubeck reviewed

View reviewed changes

irksome/dirk_stepper.py Outdated Show resolved Hide resolved

pbrubeck reviewed

View reviewed changes

irksome/dirk_stepper.py Outdated Show resolved Hide resolved

pbrubeck reviewed

View reviewed changes

irksome/dirk_stepper.py Outdated Show resolved Hide resolved

pbrubeck reviewed

View reviewed changes

irksome/dirk_stepper.py Outdated Show resolved Hide resolved

pbrubeck reviewed

View reviewed changes

irksome/dirk_stepper.py Outdated Show resolved Hide resolved

pbrubeck reviewed

View reviewed changes

irksome/dirk_stepper.py Outdated Show resolved Hide resolved

pbrubeck reviewed

View reviewed changes

irksome/explicit_stepper.py Outdated Show resolved Hide resolved

pbrubeck reviewed

View reviewed changes

irksome/explicit_stepper.py Outdated Show resolved Hide resolved

ScottMacLachlan added 2 commits

November 18, 2024 09:50


          Getting rid of getThingy

e4e193d


          Fix AAb/CCone

26d5135

pbrubeck reviewed

View reviewed changes

irksome/dirk_stepper.py Show resolved Hide resolved

ScottMacLachlan added 3 commits

November 18, 2024 12:37


          Clean up constants for BC

99659a5


          docstrings

30dde8c


          Moving AAb/CCone logic

019da1f

pbrubeck reviewed

View reviewed changes

irksome/dirk_stepper.py Outdated Show resolved Hide resolved

pbrubeck reviewed

View reviewed changes

irksome/dirk_stepper.py Show resolved Hide resolved

pbrubeck reviewed

View reviewed changes

irksome/dirk_stepper.py Outdated Show resolved Hide resolved

pbrubeck reviewed

View reviewed changes

irksome/dirk_stepper.py Show resolved Hide resolved


          Changes from review

61caa17

rckirby approved these changes

View reviewed changes

Collaborator

rckirby left a comment

This really looks great. As long as tests pass, I’m happy with it but do have a few questions. Not sure if changes to code are needed, or just my understanding.

irksome/dirk_stepper.py Show resolved Hide resolved

irksome/dirk_stepper.py Show resolved Hide resolved

irksome/dirk_stepper.py Show resolved Hide resolved

irksome/dirk_stepper.py Show resolved Hide resolved

irksome/dirk_stepper.py Show resolved Hide resolved

tests/test_explicit.py Show resolved Hide resolved


          Add warning label

3a83a5c

rckirby approved these changes

View reviewed changes

Collaborator

rckirby left a comment

Thanks!

rckirby merged commit 164cd6e into master

2 checks passed

rckirby deleted the smaclachlan/fix_dirk_bcs branch

November 20, 2024 14:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet