Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: close nav dropdown after choosing item #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: close nav dropdown after choosing item #21

wants to merge 1 commit into from

Conversation

amliu-jumptrading
Copy link
Collaborator

fix: close nav dropdown after choosing item

The event that DropdownMenu uses to trigger onSelectionChanged is being suppressed by the NavLink. Instead, we're adding an onClick callback that will close the dropdown on the dropdown items container itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atsai-jumptrading atsai-jumptrading atsai-jumptrading approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amliu-jumptrading @atsai-jumptrading