Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User management #189

Merged
merged 10 commits into from
Dec 11, 2023
Merged

User management #189

merged 10 commits into from
Dec 11, 2023

Conversation

GrishaDev
Copy link
Collaborator

@GrishaDev GrishaDev commented Aug 9, 2023

Pull Request Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes (link to the issue here)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Chore / Documentation
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Locally tested against Fireblocks API

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules
  • I have added corresponding labels to the PR

@YoavBZ YoavBZ marked this pull request as draft August 9, 2023 12:31
@YoavBZ YoavBZ changed the title draft: User management User management Aug 9, 2023
@GrishaDev GrishaDev requested a review from YoavBZ December 3, 2023 08:45
@GrishaDev GrishaDev marked this pull request as ready for review December 3, 2023 08:45
src/fireblocks-sdk.ts Outdated Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
@YoavBZ YoavBZ merged commit ce6269a into master Dec 11, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants