Skip to content

refactor(admob): upgrade quickstart to admob 20.0.0 #1277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 13, 2021

Conversation

thatfiredev
Copy link
Member

The latest version of AdMob (20.0.0) contains breaking changes. This PR should upgrade our admob quickstart to that version.


Notice that I deleted the androidTests because:

  1. They test features from the previous AdMob version.
  2. I'm not sure if they even run correctly since refactor(admob): use Jetpack's Navigation Component #1247

@samtstern samtstern merged commit 843e0ad into firebase:master Apr 13, 2021
@samtstern
Copy link
Contributor

samtstern commented Apr 13, 2021

@rosariopfernandes thank you!

@samtstern
Copy link
Contributor

@djj1109 please stop approving random PRs on this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants