Use Navigation in Firestore #1268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I6aa24b3242690820ae15e8fc5042adb6de60dee8
Change-Id: Iabde582e48e5b0998870e96a5065004ba2006c2e
Change-Id: I169cb0b1a227590255909b303a9394aea1ab7a6d
thatfiredev
reviewed
Mar 15, 2021
There was a problem hiding this comment.
@samtstern 98% looks just, we just need to fix a couple of things and I have a few suggestions:
firestore/app/src/main/java/com/google/firebase/example/fireeats/EntryChoiceActivity.kt
Outdated
Show resolved
Hide resolved
firestore/app/src/main/java/com/google/firebase/example/fireeats/java/MainActivity.java
Show resolved
Hide resolved
...re/app/src/main/java/com/google/firebase/example/fireeats/java/RestaurantDetailFragment.java
Show resolved
Hide resolved
firestore/app/src/main/java/com/google/firebase/example/fireeats/kotlin/FilterDialogFragment.kt
Show resolved
Hide resolved
...re/app/src/main/java/com/google/firebase/example/fireeats/kotlin/RestaurantDetailFragment.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Rosário Pereira Fernandes <[email protected]>
…ts/java/MainActivity.java Co-authored-by: Rosário Pereira Fernandes <[email protected]>
Change-Id: I82acd91dec0dc6119150dca7ef1888676de6587d
16 tasks
Change-Id: I11124189fc3b03e78d91dbb031bfc14e630e070d
Change-Id: I484f2bf80af2cfc38c96518a7755461a9ffb5af9
Change-Id: Ia30bb29037720fe5252f8a07756e8810030435a8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1217