refactor(admob): create a separate nav graph for the java sample #1250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rosariopfernandes good catch! By the middle of 2021 we should be able to go Kotlin-only on these samples. I'm waiting for some internal Kotlin adoption charts to hit certain thresholds and then we can get some heavy |
|
@samtstern That's some great news :) Can't wait for it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed I made a mistake when I sent #1247 : I only added the Kotlin Fragments to the navigation graph, which caused the java ones to never be used.
As a solution (in this PR), I've created a separate nav graph file for the java fragments (
nav_graph_java.xml) and the graphs are now set programmatically (instead of setting it in the XML layout).