Remove RelativeLayout from Database quickstart #1244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I594a38c19d79a38f7c2b96118c413d544f765a31
Change-Id: Id182e3abce3c478318a77c0a9a6325d4f651f977
Change-Id: I155b1506a4943a2075f920da6d7ec24e7f1808c6
Change-Id: I8684952181227160741f304bc583b36d63abd92e
Change-Id: I72615584897a5f9e381b3c9b722139853d269d55
Change-Id: I6212afad90641bfaeb74c4c2892314b666aeec63
Change-Id: I938c124d5efb3af62e7cbf194e71ca181dcc1349
Change-Id: Iedfda806d107e69d35ed8416e536d765c839249f
Change-Id: Ic961a738a58839c68ed2570eb2b9f00d315934ce
Change-Id: I380dbbb9206f000632f458f3f4b59dac041469dd
|
@rosariopfernandes I can't assign you directly but please review this one when you get a chance! |
16 tasks
thatfiredev
reviewed
Jan 12, 2021
There was a problem hiding this comment.
@samtstern I like how you used tables for the Before and After on the PR description.
These changes look really good, but I have added some comments
Change-Id: I6bb185a45ff2de03fb26121ff49706886f167091
|
@rosariopfernandes thanks for the quick comments! I think I addressed them now. |
Change-Id: Ica1abc0df166768775a23fe789319ae4f57eaac9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1217
I kept all the layouts the same except I changed a lot of the padding/margin values to be the standard 8/16/24 scale instead of the 5/10/15 that was being used in this app.
activity_main
activity_new_post
activity_post_detail
activity_sign_in
fragment_all_posts
N/A this is a FrameLayout
include_post_author
include_post_text
item_comment
item_post