Make the functions emulator work in Studio #8463
Open
+24
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleaning up some issues introduced in #8443.
Within Firebase Studio, any calls coming from the browser need to use the port forwarding hosts. However, calls coming from inside the VM can safely just use localhost. This change should keep the emulator UI using port forwarding, but let the functions emulator use localhost.
Scenarios Tested
Tested on Studio with
npx firebase/firebase-tools#jh-fns-studio, and confirmed that calls from within functions are working and calls from the emulator UI are routed to the right host.