-
Notifications
You must be signed in to change notification settings - Fork 988
feat: Add support for running functions emulator per codebase #8422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
}; | ||
|
||
for (const cfg of functionsCfg) { | ||
const codebase = cfg.codebase ?? "default"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] There is an inconsistency: the computed default value ('default') is used for filtering, but the pushed backend still uses the original cfg.codebase (which may be undefined). Consider assigning the computed value to the backend (or clarifying the intended behavior) so that filtering and backend configuration are consistent.
Copilot uses AI. Check for mistakes.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8422 +/- ##
==========================================
+ Coverage 51.20% 51.23% +0.03%
==========================================
Files 425 425
Lines 30394 30418 +24
Branches 6232 6238 +6
==========================================
+ Hits 15562 15584 +22
Misses 13442 13442
- Partials 1390 1392 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Functions emulator now only loads function codebases that are specified by the
--only
flag, e.g.Given the following function configuration in
firebase.json
:You can start the emulator to only start the
typescript
codebase by using the--only
flag like this:Fixes #4878