Update inquirer library #8411
Open
Update inquirer library #8411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inlined
force-pushed
the
inlined.inquirer
branch
from
7fcf8c0 to
63cdbc9
Compare
joehan
approved these changes
Apr 14, 2025
| /** | ||
| * Options for the checkbox function. | ||
| * | ||
| * Epxorted because Inquirer does not export its own input configs anymore. Some unused |
There was a problem hiding this comment.
Suggested change
| * Epxorted because Inquirer does not export its own input configs anymore. Some unused | |
| * Ecported because Inquirer does not export its own input configs anymore. Some unused |
| force?: boolean; | ||
| nonInteractive?: boolean; | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| /** | |
| * Exported for testing only | |
| */ |
| opts = { message: opts }; | ||
| } else { | ||
| if (opts.force) { | ||
| // TODO: Should we print what we've forced? |
There was a problem hiding this comment.
Good question - I like the idea (especially since it gives a 'paper trail' when running noninteractive commands). We probably need to audit the places we use this tho to make sure it doesn't lead to too many redundant logs
| /** | ||
| * Options for the checkbox function. | ||
| * | ||
| * Epxorted because Inquirer does not export its own input configs anymore. Some unused |
There was a problem hiding this comment.
Suggested change
| * Epxorted because Inquirer does not export its own input configs anymore. Some unused | |
| * Ecported because Inquirer does not export its own input configs anymore. Some unused |
| * Confirm if the user wants to continue | ||
| * Options for the number function. | ||
| * | ||
| * Epxorted because Inquirer does not export its own input configs anymore. Some unused |
There was a problem hiding this comment.
Suggested change
| * Epxorted because Inquirer does not export its own input configs anymore. Some unused | |
| * Exported because Inquirer does not export its own input configs anymore. Some unused |
| * Prompts for a directory name, and reprompts if that path does not exist | ||
| * Options for the checkbox function. | ||
| * | ||
| * Epxorted because Inquirer does not export its own input configs anymore. Some unused |
There was a problem hiding this comment.
Suggested change
| * Epxorted because Inquirer does not export its own input configs anymore. Some unused | |
| * Exported because Inquirer does not export its own input configs anymore. Some unused |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new inquirer library is said to have many fixes and performance improvements. Upgrade our use. While I intended to only upgrade a bit at a time, I kept pulling at the string trying to fix the graphical glitches and was never successful. Will continue trying to fix glitches in a dependent PR
Accidentally closed the last PR while trying to fix the conflicts. Recreated.