Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS #7562

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Update CODEOWNERS #7562

merged 1 commit into from
Aug 16, 2023

Conversation

hsubox76
Copy link
Contributor

Change default owners to the group, I don't think individual IDs are necessary?

I changed this in the github UI, I'm not sure what it's doing with the last line.

Change the default owner to just the jssdk-global-approvers group - I don't think individuals are required if they're part of the group?
@changeset-bot
Copy link

changeset-bot bot commented Aug 15, 2023

⚠️ No Changeset found

Latest commit: 4b63121

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hsubox76 hsubox76 marked this pull request as ready for review August 15, 2023 22:09
@hsubox76 hsubox76 requested review from dwyfrequency and a team as code owners August 15, 2023 22:09
@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

@hsubox76 hsubox76 merged commit 86f148c into master Aug 16, 2023
28 checks passed
@hsubox76 hsubox76 deleted the ch-codeowners2 branch August 16, 2023 16:19
@firebase firebase locked and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants