Don't cache FCM registration token operations. #14355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are using `defaultSessionConfiguration` as the HTTP session configuration for FCM registration token operations. https://github.com/firebase/firebase-ios-sdk/blob/a34d7ae4ed3ce143bc22d57cbda9e9341fee3df6/FirebaseMessaging/Sources/Token/FIRMessagingTokenFetchOperation.m#L111C65-L111C92 As a result, all HTTP requests and responses are cached in the `Cache.db` file. This probably isn't a security risk. Other apps cannot access the file, and even if someone got the FCM registration token, they couldn't do anything with it. They cannot just send notifications with the token alone. https://firebase.google.com/docs/cloud-messaging/auth-server But still, caching the HTTP requests and responses are unnecessary. We don't use the cache in any way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using
defaultSessionConfigurationas the HTTP session configuration for FCM registration token operations. https://github.com/firebase/firebase-ios-sdk/blob/a34d7ae4ed3ce143bc22d57cbda9e9341fee3df6/FirebaseMessaging/Sources/Token/FIRMessagingTokenFetchOperation.m#L111C65-L111C92As a result, HTTP requests and responses are cached in the
Cache.dbfile.This probably isn't a security risk. Other apps cannot access the file, and even if someone got the FCM registration token, they couldn't do anything with it. They cannot just send notifications with the token alone. https://firebase.google.com/docs/cloud-messaging/auth-server
But still, caching the HTTP requests and responses are unnecessary. We don't use the cache in any way.
Fix #14352