Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra] Simplify Client app schemes #14333

Merged
merged 2 commits into from
Jan 13, 2025
+60 −572
Merged

[Infra] Simplify Client app schemes #14333

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7ded46
[Infra] Simplify Client app schemes
ncooke3 Jan 10, 2025
9032051
Add firebase auth
ncooke3 Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Loading
Loading status checks…
Add firebase auth
@ncooke3
ncooke3 committed Jan 10, 2025
commit 903205138a8597498b933eeb3827632cf6eb7bee
27 changes: 7 additions & 20 deletions IntegrationTesting/ClientApp/ClientApp.xcodeproj/project.pbxproj
View file
Original file line number Diff line number Diff line change
@@ -13,6 +13,7 @@
EA1269B429EDF98800D79E66 /* AppDelegate.swift in Sources */ = {isa = PBXBuildFile; fileRef = EA1269B329EDF98800D79E66 /* AppDelegate.swift */; };
EA1269B829EDF98A00D79E66 /* Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = EA1269B729EDF98A00D79E66 /* Assets.xcassets */; };
EA1269BC29EDF98A00D79E66 /* Preview Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = EA1269BB29EDF98A00D79E66 /* Preview Assets.xcassets */; };
EA1FA0D12D31A8EE00DF3C07 /* FirebaseAuth in Frameworks */ = {isa = PBXBuildFile; productRef = EA1FA0D02D31A8EE00DF3C07 /* FirebaseAuth */; };
EA501B1129F09594009C4DBC /* objcxx-header-import-test.mm in Sources */ = {isa = PBXBuildFile; fileRef = EA501B1029F09593009C4DBC /* objcxx-header-import-test.mm */; };
EA5A62942A9914F300F5711A /* Preview Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = EA5A62932A9914F300F5711A /* Preview Assets.xcassets */; };
EA5A62992A99498500F5711A /* Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = EA1269B729EDF98A00D79E66 /* Assets.xcassets */; };
@@ -56,10 +57,6 @@
EA5A62932A9914F300F5711A /* Preview Assets.xcassets */ = {isa = PBXFileReference; lastKnownFileType = folder.assetcatalog; path = "Preview Assets.xcassets"; sourceTree = "<group>"; };
EA7DF54229EF20B9005664A7 /* swift-import-test.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "swift-import-test.swift"; sourceTree = "<group>"; };
EA7DF54929EF2A92005664A7 /* firebase-ios-sdk */ = {isa = PBXFileReference; lastKnownFileType = wrapper; name = "firebase-ios-sdk"; path = ../../; sourceTree = "<group>"; };
EAA0A9972AD8495000C28FCD /* ClientApp_CocoaPods_iOS13.entitlements */ = {isa = PBXFileReference; lastKnownFileType = text.plist.entitlements; path = ClientApp_CocoaPods_iOS13.entitlements; sourceTree = "<group>"; };
EAA0A9992AD8495000C28FCD /* Preview Assets.xcassets */ = {isa = PBXFileReference; lastKnownFileType = folder.assetcatalog; path = "Preview Assets.xcassets"; sourceTree = "<group>"; };
EAA0A9B92AD84E0900C28FCD /* ClientApp_iOS13.entitlements */ = {isa = PBXFileReference; lastKnownFileType = text.plist.entitlements; path = ClientApp_iOS13.entitlements; sourceTree = "<group>"; };
EAA0A9BB2AD84E0900C28FCD /* Preview Assets.xcassets */ = {isa = PBXFileReference; lastKnownFileType = folder.assetcatalog; path = "Preview Assets.xcassets"; sourceTree = "<group>"; };
/* End PBXFileReference section */

/* Begin PBXFrameworksBuildPhase section */
@@ -78,6 +75,7 @@
EA7DF5AB29EF3327005664A7 /* FirebaseMessaging in Frameworks */,
EA7DF59329EF3326005664A7 /* FirebaseCrashlytics in Frameworks */,
EA7DF5A529EF3327005664A7 /* FirebaseInAppMessaging-Beta in Frameworks */,
EA1FA0D12D31A8EE00DF3C07 /* FirebaseAuth in Frameworks */,
EA7DF5B729EF3328005664A7 /* FirebaseStorageCombine-Community in Frameworks */,
EA7DF5B129EF3328005664A7 /* FirebaseRemoteConfig in Frameworks */,
EA7DF5A129EF3327005664A7 /* FirebaseFunctions in Frameworks */,
@@ -182,22 +180,6 @@
path = Shared;
sourceTree = "<group>";
};
EAA0A9982AD8495000C28FCD /* Preview Content */ = {
isa = PBXGroup;
children = (
EAA0A9992AD8495000C28FCD /* Preview Assets.xcassets */,
);
path = "Preview Content";
sourceTree = "<group>";
};
EAA0A9BA2AD84E0900C28FCD /* Preview Content */ = {
isa = PBXGroup;
children = (
EAA0A9BB2AD84E0900C28FCD /* Preview Assets.xcassets */,
);
path = "Preview Content";
sourceTree = "<group>";
};
/* End PBXGroup section */

/* Begin PBXNativeTarget section */
@@ -234,6 +216,7 @@
EA7DF5B029EF3328005664A7 /* FirebaseRemoteConfig */,
EA7DF5B629EF3328005664A7 /* FirebaseStorageCombine-Community */,
EA0BC0FE29F06D5B005B8AEE /* FirebaseAnalyticsOnDeviceConversion */,
EA1FA0D02D31A8EE00DF3C07 /* FirebaseAuth */,
);
productName = ClientApp;
productReference = EA1269B029EDF98800D79E66 /* ClientApp.app */;
@@ -650,6 +633,10 @@
isa = XCSwiftPackageProductDependency;
productName = FirebaseAnalyticsOnDeviceConversion;
};
EA1FA0D02D31A8EE00DF3C07 /* FirebaseAuth */ = {
isa = XCSwiftPackageProductDependency;
productName = FirebaseAuth;
};
EA7DF58229EF3326005664A7 /* FirebaseAnalytics */ = {
isa = XCSwiftPackageProductDependency;
productName = FirebaseAnalytics;

Unchanged files with check annotations Beta

View file
Firestore/core/src/local/local_store.cc
}
int LocalStore::Backfill() const {
return persistence_->Run("Backfill Indexes", [&] {

Check warning on line 589 in Firestore/core/src/local/local_store.cc

GitHub Actions / client-app-spm-source-firestore (iOS, ClientApp) 

implicit conversion loses integer precision: 'typename std::enable_if<!std::is_same<void, decltype(block())>::value, decltype(block())>::type' (aka 'unsigned long') to 'int' [-Wshorten-64-to-32]
return index_backfiller_->WriteIndexEntries(this);
});
}