Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Config] Port 'RCNConfigFetch' #14286

Merged
merged 8 commits into from
Dec 27, 2024
Merged

[Config] Port 'RCNConfigFetch' #14286

merged 8 commits into from
Dec 27, 2024

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Dec 26, 2024

#no-changelog

Copy link
Contributor

github-actions bot commented Dec 26, 2024

Apple API Diff Report

Commit: ed9f72c
Last updated: Fri Dec 27 13:59 PST 2024
View workflow logs & download artifacts


FirebaseRemoteConfig

Classes

FIRRemoteConfig
[REMOVED] -initWithAppName:FIROptions:namespace:DBManager:configContent:userDefaults:analytics:
Swift:
-  init ( appName : String , firOptions options : FIROptions , namespace FIRNamespace : String , dbManager DBManager : RCNConfigDBManager , configContent : RCNConfigContent , userDefaults : UserDefaults ?, analytics : ( any FIRAnalyticsInterop )?)
Objective-C:
-  - ( instancetype ) initWithAppName :( NSString * ) appName FIROptions :( FIROptions * ) options namespace :( NSString * ) FIRNamespace DBManager :( RCNConfigDBManager * ) DBManager configContent :( RCNConfigContent * ) configContent userDefaults :( nullable NSUserDefaults * ) userDefaults analytics :( nullable id < FIRAnalyticsInterop > ) analytics ;
[ADDED] -initWithAppName:FIROptions:namespace:DBManager:configContent:userDefaults:analytics:configFetch:
Swift:
+  init ( appName : String , firOptions options : FIROptions , namespace FIRNamespace : String , dbManager DBManager : RCNConfigDBManager , configContent : RCNConfigContent , userDefaults : UserDefaults ?, analytics : ( any FIRAnalyticsInterop )?, configFetch : RCNConfigFetch ?)
Objective-C:
+  - ( instancetype ) initWithAppName :( NSString * ) appName FIROptions :( FIROptions * ) options namespace :( NSString * ) FIRNamespace DBManager :( RCNConfigDBManager * ) DBManager configContent :( RCNConfigContent * ) configContent userDefaults :( nullable NSUserDefaults * ) userDefaults analytics :( nullable id < FIRAnalyticsInterop > ) analytics configFetch :( nullable RCNConfigFetch * ) configFetch ;

@ncooke3 ncooke3 marked this pull request as ready for review December 27, 2024 20:56
@ncooke3 ncooke3 requested a review from paulb777 December 27, 2024 20:56
@paulb777
Copy link
Member

Would you look at these test failures in Value.swift - https://github.com/firebase/firebase-ios-sdk/actions/runs/12520611431/job/34926546021?pr=14286#step:6:77

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after comment review and satisfactory tests

FirebaseRemoteConfig/SwiftNew/ConfigFetch.swift Outdated Show resolved Hide resolved
FirebaseRemoteConfig/SwiftNew/ConfigFetch.swift Outdated Show resolved Hide resolved
@ncooke3
Copy link
Member Author

ncooke3 commented Dec 27, 2024

Failures look similar to that in #14284: https://github.com/firebase/firebase-ios-sdk/actions/runs/12506161513/job/34890668118?pr=14284

The catalyst test failure seems new but the unit test is the same flaky one as in ^.

@ncooke3 ncooke3 merged commit cabace9 into rc-swift Dec 27, 2024
30 of 32 checks passed
@ncooke3 ncooke3 deleted the nc/rc-swift-4 branch December 27, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants