[Config] Port 'RCNConfigSettings' #14262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulb777
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Is this tvos pll test failure actionable?
- NOTE | [tvOS] xcodebuild: /Users/runner/work/firebase-ios-sdk/firebase-ios-sdk/FirebaseRemoteConfig/Tests/Unit/RCNRemoteConfigTest.m:1514: error: -[RCNRemoteConfigTest testFetchRequestWithUserPropertiesOnly] : (([req containsString:@"analytics_user_properties:{\"user_key\":\"user_value\"}"]) is true) failed
ncooke3
force-pushed
the
nc/rc-swift-3
branch
from
df1f33f to
55a7d9d
Compare
|
Can address any extra feedback in a follow-up PR. There was one CI failure that I couldn't reproduce locally, but it also appeared in #14252 so proceeding with merge. Likely related to atomicity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#no-changelog