Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Config] Port 'FIRRemoteConfigComponent' #14252

Merged
merged 3 commits into from
Dec 16, 2024
Merged

[Config] Port 'FIRRemoteConfigComponent' #14252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1084045
[Config] Port 'FIRRemoteConfigComponent'
ncooke3 Dec 13, 2024
e4a895c
Remove extra API
ncooke3 Dec 13, 2024
534ea5c
review
ncooke3 Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions FirebaseCore/Sources/FIRApp.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -805,6 +805,7 @@ + (void)registerSwiftComponents {
NSDictionary<NSString *, NSString *> *swiftComponents = @{
@"FIRSessions" : @"fire-ses",
@"FIRAuthComponent" : @"fire-auth",
@"FIRRemoteConfigComponent" : @"fire-rc",
};
for (NSString *className in swiftComponents.allKeys) {
Class klass = NSClassFromString(className);
Expand Down
1 change: 0 additions & 1 deletion FirebaseRemoteConfig/Sources/FIRRemoteConfig.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@

#import "FirebaseABTesting/Sources/Private/FirebaseABTestingInternal.h"
#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
#import "FirebaseRemoteConfig/Sources/FIRRemoteConfigComponent.h"
#import "FirebaseRemoteConfig/Sources/Private/FIRRemoteConfig_Private.h"
#import "FirebaseRemoteConfig/Sources/Private/RCNConfigFetch.h"
#import "FirebaseRemoteConfig/Sources/Private/RCNConfigSettings.h"
Expand Down
64 changes: 0 additions & 64 deletions FirebaseRemoteConfig/Sources/FIRRemoteConfigComponent.h
View file
Open in desktop

This file was deleted.

151 changes: 0 additions & 151 deletions FirebaseRemoteConfig/Sources/FIRRemoteConfigComponent.m
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions FirebaseRemoteConfig/Sources/Private/FIRRemoteConfig_Private.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
@class RCNConfigFetch;
@class RCNConfigRealtime;
@protocol FIRAnalyticsInterop;
@protocol FIRRolloutsStateSubscriber;

NS_ASSUME_NONNULL_BEGIN

Expand All @@ -49,9 +48,6 @@ NS_ASSUME_NONNULL_BEGIN
+ (FIRRemoteConfig *)remoteConfigWithFIRNamespace:(NSString *)remoteConfigNamespace
NS_SWIFT_NAME(remoteConfig(FIRNamespace:));

/// Register RolloutsStateSubcriber to FIRRemoteConfig instance
- (void)addRemoteConfigInteropSubscriber:(id<FIRRolloutsStateSubscriber> _Nonnull)subscriber;

@end

NS_ASSUME_NONNULL_END
5 changes: 5 additions & 0 deletions FirebaseRemoteConfig/Sources/Public/FirebaseRemoteConfig/FIRRemoteConfig.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
@class FIRRemoteConfigValue;
@protocol FIRAnalyticsInterop;

@protocol FIRRolloutsStateSubscriber;

/// The Firebase Remote Config service default namespace, to be used if the API method does not
/// specify a different namespace. Use the default namespace if configuring from the Google Firebase
/// service.
Expand Down Expand Up @@ -354,5 +356,8 @@ typedef void (^FIRRemoteConfigUpdateCompletion)(FIRRemoteConfigUpdate *_Nullable
userDefaults:(nullable NSUserDefaults *)userDefaults
analytics:(nullable id<FIRAnalyticsInterop>)analytics;

/// Register `FIRRolloutsStateSubscriber` to `FIRRemoteConfig` instance
- (void)addRemoteConfigInteropSubscriber:(id<FIRRolloutsStateSubscriber> _Nonnull)subscriber;

@end
NS_ASSUME_NONNULL_END
Loading
Loading