-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Auth] Add support for upcoming Recaptcha changes #14201
base: main
Are you sure you want to change the base?
Conversation
Generated by 🚫 Danger |
FirebaseAuth/Sources/Swift/Utilities/AuthRecaptchaVerifier.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll refactor this further in a following PR. It more easily reviewable now as it's a direct port of the ObjC bridge logic.
Adding this to M158 milestone for consideration. Will probably slip to M159. |
@@ -1,3 +1,7 @@ | |||
# Unreleased | |||
- [changed] Using reCAPTCHA Enterprise and Firebase Auth requires reCAPTCHA | |||
Enterprise X.Y.Z or later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: update with final Recaptcha version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And the Recaptcha non-beta version publishing gates the merge.
// let client = try await recaptcha.fetchClient(withSiteKey: siteKey) | ||
let client = try await recaptcha.getClient(withSiteKey: siteKey) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when recaptcha SDK is released:
// let client = try await recaptcha.fetchClient(withSiteKey: siteKey) | |
let client = try await recaptcha.getClient(withSiteKey: siteKey) | |
let client = try await recaptcha.fetchClient(withSiteKey: siteKey) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting rid of the ObjC!
Corresponding PR for google/interop-ios-for-google-sdks#16
that is backwards compatible for Recaptcha ≤18.6(edit: backwards compatible is not needed due to dependency versioning)Support Cases
Testing (manual tests– is reCaptcha token generated?)
TODOs
cc: @walterjgsp