Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vertex AI] Replace legacy errors in GenerativeAIService #14036

Merged
merged 3 commits into from
Nov 5, 2024
Merged

[Vertex AI] Replace legacy errors in GenerativeAIService #14036

merged 3 commits into from
Nov 5, 2024

Conversation

andrewheard
Copy link
Contributor

Replaced NSError objects that originated from the generative-ai-swift SDK (domain: "com.google.generative-ai").

#no-changelog

@andrewheard andrewheard added this to the 11.5.0 - M156 milestone Nov 5, 2024
@andrewheard andrewheard marked this pull request as ready for review November 5, 2024 20:47
@andrewheard andrewheard requested a review from ncooke3 November 5, 2024 20:47
@andrewheard andrewheard merged commit ba7325c into main Nov 5, 2024
38 checks passed
@andrewheard andrewheard deleted the ah/vertex-service-errors branch November 5, 2024 21:32
@github-actions github-actions bot mentioned this pull request Nov 13, 2024
Merged
@firebase firebase locked and limited conversation to collaborators Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ncooke3 ncooke3 ncooke3 approved these changes

Assignees
No one assigned
Labels
api: vertexai
Projects
None yet
Milestone
11.5.0 - M156
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewheard @ncooke3