Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vertex AI] Add CI for visionOS #13092

Merged
merged 13 commits into from
Jun 10, 2024
Merged

[Vertex AI] Add CI for visionOS #13092

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
096296a
[Vertex AI] Add CI for visionOS
andrewheard Jun 6, 2024
df4d4c8
Switch to Xcode 15.3 for visionOS CI
andrewheard Jun 6, 2024
b79adb6
Temporarily disable testModelContentFromInvalidCIImageThrows
andrewheard Jun 7, 2024
caf8e74
Temporarily disable PartsRepresentableTests on visionOS
andrewheard Jun 7, 2024
427f186
Re-enable PartsRepresentableTests and switch to Xcode 15.4
andrewheard Jun 7, 2024
72ad9b4
Disable testModelContentFromInvalidUIImageThrows, revert to Xcode 15.2
andrewheard Jun 7, 2024
57af3d6
Disable testModelContentFromUIImageIsNotEmpty, switch to #elseif canI…
andrewheard Jun 7, 2024
7730403
Re-enable tests
andrewheard Jun 7, 2024
1205836
Revert "Re-enable tests"
andrewheard Jun 7, 2024
d36111e
Reformat and add comment
andrewheard Jun 7, 2024
119ea9f
Try alternative test implementations
andrewheard Jun 7, 2024
98c0fb9
Revert "Try alternative test implementations"
andrewheard Jun 7, 2024
583bca7
Merge branch 'main' into ah/vertex-visionos
andrewheard Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/vertexai.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
spm-unit:
strategy:
matrix:
target: [iOS, macOS, catalyst]
target: [iOS, macOS, catalyst, visionOS]
os: [macos-14]
include:
- os: macos-14
Expand Down
7 changes: 4 additions & 3 deletions FirebaseVertexAI/Tests/Unit/PartsRepresentableTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import FirebaseVertexAI
import XCTest
#if canImport(UIKit)
import UIKit
#else
#elseif canImport(AppKit)
import AppKit
#endif

Expand Down Expand Up @@ -73,7 +73,7 @@ final class PartsRepresentableTests: XCTestCase {
XCTFail("Expected model content from invlaid image to error")
}

#if canImport(UIKit)
#if canImport(UIKit) && !os(visionOS) // These tests are stalling in CI on visionOS.
func testModelContentFromInvalidUIImageThrows() throws {
let image = UIImage()
do {
Expand Down Expand Up @@ -103,7 +103,8 @@ final class PartsRepresentableTests: XCTestCase {
let modelContent = try image.tryPartsValue()
XCTAssert(modelContent.count > 0, "Expected non-empty model content for UIImage: \(image)")
}
#else

#elseif canImport(AppKit)
func testModelContentFromNSImageIsNotEmpty() throws {
let coreImage = CIImage(color: CIColor.red)
.cropped(to: CGRect(origin: CGPointZero, size: CGSize(width: 16, height: 16)))
Expand Down
Loading