[v11] Simplify Component System Usage #13047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulb777
requested review from
aashishpatil-g,
ncooke3,
ryanwilson and
andrewheard
andrewheard
reviewed
Jun 3, 2024
paulb777
force-pushed
the
pb-component-cleanup
branch
from
4f46050 to
6106f13
Compare
andrewheard
approved these changes
Jun 3, 2024
|
Going to merge here. I'll address any additional comments in a future PR |
ncooke3
reviewed
Jun 4, 2024
|
|
||
| /// A map of active instances, grouped by app. Keys are FirebaseApp names and values are arrays | ||
| /// containing all instances of Storage associated with the given app. | ||
| private static var instances: [String: Storage] = [:] |
There was a problem hiding this comment.
Found a small inconsistency between the comment and the code:
/// values are arrays containing all instances of Storage associated with the given app.but
values are not arrays
private static var instances: [String: Storage] = [:]
Comment on lines
+120
to
+122
| /// Class to enable VertexAI to register via the Objective-C based Firebase component system. | ||
| @objc(FIRVertexAIComponent) class FirebaseVertexAIComponent: NSObject {} | ||
|
|
There was a problem hiding this comment.
No, see updated comment in #13055
pragatimodi
pushed a commit
that referenced
this pull request
Jun 10, 2024
pragatimodi
pushed a commit
that referenced
this pull request
Jun 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Component class is not needed for products that don't need to do early initialization and if all of their dependencies are Eager components.
Only registerLibrary needs to run for userAgent configuration. This is done by checking for the existence of an
objcclass in FIRApp.m. If one doesn't exist at all a singleton empty@objcclass is added. See the example in VertexAI.swift.Fix a Storage unit test that was dependent on a race condition to pass. (URL overrides the bucket name when it pre-existed)
Fix #12957
TODO: Investigate deleting the
FIRDependencyclass which seems to be ignored.#no-changelog