Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[auth-swift] Merge main #13034

Merged
merged 108 commits into from
May 29, 2024
Merged

[auth-swift] Merge main #13034

merged 108 commits into from
May 29, 2024

Conversation

paulb777
Copy link
Member

#no-changelog

andrewheard and others added 30 commits April 30, 2024 17:37
This reverts commit af7d783.

# Conflicts:
#	FirebaseVertexAI/Sources/VertexAI.swift
#	Package.swift
Co-authored-by: Morgan Chen <[email protected]>
Co-authored-by: Paul Beusterien <[email protected]>
Co-authored-by: Peter Friese <[email protected]>
Co-authored-by: Ryan Wilson <[email protected]>
Co-authored-by: Morgan Chen <[email protected]>
Co-authored-by: Paul Beusterien <[email protected]>
Co-authored-by: Peter Friese <[email protected]>
Co-authored-by: Ryan Wilson <[email protected]>
@ncooke3
Copy link
Member

ncooke3 commented May 29, 2024

Is this just a result of:

git fetch origin
git checkout auth-swift
git pull
git checkout -b  pb-merge-main-529
git merge main
# resolve conflicts and commit

?

Copy link
Contributor

github-actions bot commented May 29, 2024

Apple API Diff Report

Commit: a8df55c
Last updated: Wed May 29 16:11 PDT 2024
View workflow logs & download artifacts


[BUILD ERROR] FirebaseSharedSwift


@paulb777
Copy link
Member Author

Yes.

@ncooke3
Copy link
Member

ncooke3 commented May 29, 2024

The SPM failures will be fixed by #13016. I don't quite understand the cocoapods-integration / tests (pull_request) failure.

@paulb777
Copy link
Member Author

I'll disregard the failures that will be fixed by #13016.

a5c6721 should fix the CocoaPods integration tests

@paulb777 paulb777 merged commit a5c6721 into auth-swift May 29, 2024
450 of 467 checks passed
@paulb777 paulb777 deleted the pb-merge-main-529 branch May 29, 2024 23:24
@firebase firebase locked and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.