Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vertex AI] Add basic checks for invalid model names #12923

Merged
merged 1 commit into from
May 9, 2024
Merged

[Vertex AI] Add basic checks for invalid model names #12923

merged 1 commit into from
May 9, 2024

Conversation

andrewheard
Copy link
Contributor

  • Added checks to prevent space, newline or / characters in model names, similar to locations.
  • Updated supported location links to point to Firebase docs.

#no-changelog

@andrewheard andrewheard requested a review from paulb777 May 8, 2024 22:19
@andrewheard andrewheard merged commit 60c3448 into release-10.26 May 9, 2024
42 checks passed
@andrewheard andrewheard deleted the ah/vertex-model-names branch May 9, 2024 14:41
andrewheard added a commit that referenced this pull request May 13, 2024
@andrewheard
[Vertex AI] Add basic checks for invalid model names (#12923)
839e626
andrewheard added a commit that referenced this pull request May 13, 2024
@andrewheard
[Vertex AI] Add basic checks for invalid model names (#12923)
73a1dd9
@firebase firebase locked and limited conversation to collaborators Jun 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: vertexai
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewheard @paulb777