Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Update changelogs for user defaults migration PRs #12774

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Apr 12, 2024

I recently merged PRs to migrate away from user defaults for the following SDKs:

  • App Check
  • Performance
  • Sessions
  • InAppMessaging
  • Database

I'm updating each's changelog with the exception of Sessions because Sessions does not have a changelog. So, I'm ensuring that its clients, Crashlytics & Performance, mention this in their changelogs.

#no-changelog

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The AppCheckCore dependency should be updated in both CocoaPods and SPM, so AppCheck doesn't pull in a required reason from its deps.

Can be done in a future PR after AppCheckCore publishes.

FirebaseAppCheck/CHANGELOG.md Outdated Show resolved Hide resolved
@google-oss-bot
Copy link

google-oss-bot commented Apr 12, 2024

Coverage Report 1

Affected Products

  • FirebaseDatabase-iOS-FirebaseDatabase.framework

    Overall coverage changed from 0.02% (b6e5270) to 56.76% (2daee9f) by +56.74%.

    87 individual files with coverage change

    FilenameBase (b6e5270)Merge (2daee9f)Diff
    APLevelDB.mm0.00%61.30%+61.30%
    FAckUserWrite.m0.00%83.33%+83.33%
    FArraySortedDictionary.m0.00%97.49%+97.49%
    FAtomicNumber.m0.00%100.00%+100.00%
    fbase64.c0.00%32.00%+32.00%
    FCacheNode.m0.00%100.00%+100.00%
    FCachePolicy.m0.00%17.14%+17.14%
    FChange.m0.00%88.24%+88.24%
    FChildChangeAccumulator.m0.00%65.22%+65.22%
    FChildrenNode.m0.00%91.16%+91.16%
    FClock.m0.00%100.00%+100.00%
    FCompoundHash.m0.00%97.70%+97.70%
    FCompoundWrite.m0.00%91.12%+91.12%
    FConnection.m0.00%26.81%+26.81%
    FDataEvent.m0.00%29.41%+29.41%
    FEmptyNode.m0.00%100.00%+100.00%
    FEventGenerator.m0.00%95.37%+95.37%
    FEventRaiser.m0.00%33.33%+33.33%
    FImmutableSortedDictionary.m0.00%31.03%+31.03%
    FImmutableSortedSet.m0.00%54.22%+54.22%
    FImmutableTree.m0.00%85.75%+85.75%
    FIndex.m0.00%91.67%+91.67%
    FIndexedFilter.m0.00%96.38%+96.38%
    FIndexedNode.m0.00%97.06%+97.06%
    FIRDatabase.m0.00%15.76%+15.76%
    FIRDatabaseComponent.m3.85%19.23%+15.38%
    FIRDatabaseConfig.m0.00%59.62%+59.62%
    FIRDatabaseConnectionContextProvider.m0.00%96.67%+96.67%
    FIRDatabaseQuery.m0.00%3.86%+3.86%
    FIRDatabaseReference.m0.00%6.41%+6.41%
    FIRDataSnapshot.m0.00%89.71%+89.71%
    FIRMutableData.m0.00%75.51%+75.51%
    FIRRetryHelper.m0.00%83.33%+83.33%
    FKeyIndex.m0.00%60.56%+60.56%
    FLeafNode.m0.00%86.98%+86.98%
    FLevelDBStorageEngine.m0.00%71.40%+71.40%
    FLimitedFilter.m0.00%97.25%+97.25%
    FLLRBEmptyNode.m0.00%75.00%+75.00%
    FLLRBValueNode.m0.00%85.39%+85.39%
    FMaxNode.m0.00%60.61%+60.61%
    FMerge.m0.00%87.18%+87.18%
    FNamedNode.m0.00%62.32%+62.32%
    FNextPushId.m0.00%62.50%+62.50%
    FOperationSource.m0.00%89.29%+89.29%
    FOverwrite.m0.00%81.48%+81.48%
    FPath.m0.00%94.30%+94.30%
    FPathIndex.m0.00%88.75%+88.75%
    FPersistenceManager.m0.00%55.19%+55.19%
    FPersistentConnection.m0.00%21.26%+21.26%
    FPriorityIndex.m0.00%87.84%+87.84%
    FPruneForest.m0.00%93.08%+93.08%
    FQueryParams.m0.00%96.24%+96.24%
    FQuerySpec.m0.00%86.36%+86.36%
    FRangedFilter.m0.00%93.67%+93.67%
    FRangeMerge.m0.00%94.06%+94.06%
    FRepo.m0.00%13.48%+13.48%
    FRepoInfo.m0.00%73.00%+73.00%
    FRepoManager.m0.00%29.86%+29.86%
    FServerValues.m0.00%50.85%+50.85%
    FSnapshotHolder.m0.00%100.00%+100.00%
    FSnapshotUtilities.m0.00%62.06%+62.06%
    FSparseSnapshotTree.m0.00%98.13%+98.13%
    FSRWebSocket.m0.00%38.14%+38.14%
    FStringUtilities.m0.00%79.41%+79.41%
    FSyncPoint.m0.00%87.80%+87.80%
    FSyncTree.m0.00%71.33%+71.33%
    FTrackedQuery.m0.00%75.38%+75.38%
    FTrackedQueryManager.m0.00%90.50%+90.50%
    FTransformedEnumerator.m0.00%100.00%+100.00%
    FTree.m0.00%6.04%+6.04%
    FTreeNode.m0.00%100.00%+100.00%
    FTreeSortedDictionary.m0.00%96.17%+96.17%
    FTreeSortedDictionaryEnumerator.m0.00%100.00%+100.00%
    FTuplePathValue.m0.00%100.00%+100.00%
    FTupleRemovedQueriesEvents.m0.00%100.00%+100.00%
    FUtilities.m0.00%74.01%+74.01%
    FValidation.m0.00%25.32%+25.32%
    FValueIndex.m0.00%48.53%+48.53%
    FView.m0.00%80.11%+80.11%
    FViewCache.m0.00%100.00%+100.00%
    FViewProcessor.m0.00%91.87%+91.87%
    FViewProcessorResult.m0.00%100.00%+100.00%
    FWebSocketConnection.m0.00%37.19%+37.19%
    FWriteRecord.m0.00%45.65%+45.65%
    FWriteTree.m0.00%75.44%+75.44%
    FWriteTreeRef.m0.00%100.00%+100.00%
    NSData+SRB64Additions.m0.00%81.82%+81.82%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/5y4R0EHo0M.html

@ncooke3 ncooke3 merged commit 46b7c0d into main Apr 12, 2024
134 of 152 checks passed
@ncooke3 ncooke3 deleted the nc/changelogs branch April 12, 2024 18:41
@firebase firebase locked and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants