Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Release Tooling] Stop including 'Info.plist's in static xcframeworks (#12243)" #12396

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Feb 15, 2024

This reverts commit 0fa8498.

Fix #12390

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm the presence of the plist in the generated zip.

@paulb777 paulb777 added this to the 10.22.0 - M144 milestone Feb 15, 2024
@paulb777
Copy link
Member

And add a release note.

@ncooke3 ncooke3 requested a review from paulb777 February 15, 2024 23:41
@ncooke3
Copy link
Member Author

ncooke3 commented Feb 15, 2024

Release note added and verified that platform framework plists are back.

@ncooke3 ncooke3 enabled auto-merge (squash) February 15, 2024 23:41
@ncooke3
Copy link
Member Author

ncooke3 commented Feb 15, 2024

Still working on the second piece, which involves changing how resources are bundled. Will open another PR for that.

@ncooke3 ncooke3 disabled auto-merge February 16, 2024 00:22
@ncooke3 ncooke3 merged commit ca77625 into main Feb 16, 2024
5 checks passed
@ncooke3 ncooke3 deleted the nc/revert-plist branch February 16, 2024 00:22
@TakasurAtWork
Copy link

Is it released yet? I am facing an issue with Xcode 15.3 stable.

@ncooke3
Copy link
Member Author

ncooke3 commented Mar 6, 2024

@TakasurAtWork, yes. Please update to the latest Firebase version, 10.22.0. If you run into any issues, please open an issue and I'll help triage.

@firebase firebase locked and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xcode 15.3b3: app installation failed due to missing Info.plist
4 participants