Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix health-metrics #12345

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Fix health-metrics #12345

merged 2 commits into from
Feb 2, 2024

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Feb 1, 2024

Downversion to actions/upload-artifact@v3

The new upload-artifact version from #12337 broke the health metrics presubmit job - https://github.com/firebase/firebase-ios-sdk/actions/runs/7748205614/job/21130380583

With the provided path, there will be 41 files uploaded
Artifact name is valid!
Root directory input is valid!
Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

The failures are related to actions/upload-artifact#478. We need a resolution before going to actions/upload-artifact@v4

@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseDynamicLinks-iOS-FirebaseDynamicLinks.framework

    Overall coverage changed from ? (true) to 61.52% (d5b21be) by ?.

    15 individual files with coverage change

    FilenameBase (true)Merge (d5b21be)Diff
    FDLDeviceHeuristicsHelper.m?0.00%?
    FDLLogging.m?58.62%?
    FDLURLComponents.m?82.31%?
    FDLUtilities.m?75.40%?
    FIRDLDefaultRetrievalProcessV2.m?14.04%?
    FIRDLJavaScriptExecutor.m?24.81%?
    FIRDLRetrievalProcessFactory.m?100.00%?
    FIRDLRetrievalProcessResult.m?100.00%?
    FIRDLScionLogging.m?100.00%?
    FIRDynamicLink.m?74.07%?
    FIRDynamicLinkComponentsKeyProvider.m?83.33%?
    FIRDynamicLinkNetworking.m?45.09%?
    FIRDynamicLinks.m?71.30%?
    GINArgument.m?0.00%?
    GINInvocation.m?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/xJqrtTUY2W.html

@paulb777 paulb777 force-pushed the pb-fix-upload-artifact branch from 96169da to 041b39a Compare February 2, 2024 00:09
@paulb777 paulb777 enabled auto-merge (squash) February 2, 2024 00:40
@paulb777 paulb777 merged commit d603c7b into main Feb 2, 2024
37 checks passed
@paulb777 paulb777 deleted the pb-fix-upload-artifact branch February 2, 2024 15:08
@firebase firebase locked and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants