Update README.md for visionOS #12293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewheard
approved these changes
Jan 17, 2024
ncooke3
approved these changes
Jan 17, 2024
morganchen12
approved these changes
Jan 17, 2024
peterfriese
reviewed
Jan 17, 2024
| @@ -237,14 +237,25 @@ To receive push notifications, follow the steps above and run the app on a physi | |||
|
|
|||
| ## Building with Firebase on Apple platforms | |||
|
|
|||
| Firebase 8.9.0 introduced official beta support for macOS, Catalyst, and tvOS. watchOS continues | |||
| to be community supported. Thanks to community contributions for many of the multi-platform PRs. | |||
| Firebase 8.9.0 introduced official beta support for macOS, Catalyst, and tvOS. visionOS and watchOS | |||
There was a problem hiding this comment.
This is a bit confusing.
The first part of the sentence mentions Firebase 8.9.0, which adds macOS, Catalyst, and tvOS. It goes on to talk about visionOS.
I think we should write "In Firebase 10.xx.x, we added support for visionOS. visionOS and watchOS are community-supported...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#no-changelog
See also internal cl/599193113 for updates to the platform support table matrix